new: Deploy and monitor ML models with GPUs on Amazon EKS #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eks-workshop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shivkumr
changed the title
|
Karpenter should be preinstalled in this lab as it doesn't really add much to the lab. Take a look at the Inference with AWS Inferentia lab (https://www.eksworkshop.com/docs/aiml/inferentia/). This lab comes with Karpenter preinstalled. In the Jupyter Notebook commands section it would be nice to get some explanation on what this code is exactly doing. This would also enable to user to read through the explanation while waiting for the code to be executed. Other than that this lab looks really good! Thank you for creating it. |
bkgardiner
approved these changes
Sep 12, 2024
niallthomson
changed the title
svennam92
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Awesome! Some comments:
- The prepare-environment block should have a link out to the Terraform like in other modules
- Please explain hardware infrastructure being used. Can we outline the Karpenter nodepools that are created for the user? Explain what g5 instances are and why we need them for the lab. Example: https://eksworkshop.com/docs/aiml/chatbot/nodepool
- The titles are for the AI/ML modules are not distinct enough. How about something like "Training StableDiffusion on NVIDIA GPUs". Deploying and inference is implied when we're doing training.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a new lab to deploy and monitor ML model on Amazon EKS
Which issue(s) this PR fixes:
First PR for this new lab
Fixes # NA
Quality checks
My content adheres to the style guidelines
I ran
make test module="<module>"it was successful (see https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/automated_tests.md)EKS Workshop
AI/ML on EKS
Deploy and Monitor GenAI Model on EKS
✔ Deploy and Monitor GenAI Model on EKS (1342913ms)
✔ Install Karpenter and KubeRay Operator (211251ms)
✔ Install Jupyterhub (444619ms)
✔ Model Training (60899ms)
✔ Model Inference (312600ms)
✔ Monitor GPU Workloads on EKS (4945ms)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.